search

eclipse-emfcloud / emfcloud-modelserver

Modelserver component
Other
40 stars 21 forks source link

Improve Codec handling for multi module use #231

Closed eneufeld closed 1 year ago

eneufeld commented 1 year ago

Currently Codecs are only registered using the format they support. This is not enough if different codecs are needed for the same format but different models. The new API uses a CodecProvider that can be used with a bazaar pattern so that the best fitting CodecProvider can be retrieved.

Fix #230

cdamus commented 1 year ago

Oops, sorry, I didn't notice that this PR was just a draft and now I cannot dismiss my review because it's a draft.

eneufeld commented 1 year ago

good catches, I will add those, thank you!

ndoschek commented 1 year ago

Thanks Eugen! I didn't have time to look into it yet, but regarding the build, the EMF tests are failing that are only included in the m2 build (due to known issues in the p2 environment, see also #167).

eneufeld commented 1 year ago

Good thing we have the tests running ;-) . Thank you for seeing this. Updated the test mock setup to fix the test.