search

eclipse-emfcloud / emfcloud-modelserver

Modelserver component
Other
40 stars 21 forks source link

With command edit API, use SetCommand on a containment feature (#257) #258

Closed vhemery closed 1 year ago

vhemery commented 1 year ago

Fixing SetCommandContribution: enable usage of SetCommand on monovalued containment features.

Signed-off-by: vhemery vincent.hemery@bonitasoft.com

vhemery commented 1 year ago

Looks like org.eclipse.emfcloud.modelserver.emf.common.DefaultModelSynchronizerTest.setup is failing, but even without the modifications... Build https://ci.eclipse.org/emfcloud/job/eclipse-emfcloud/job/emfcloud-modelserver/job/issues%252F257/1/ was failing with this test too, at branch creation from master...

ndoschek commented 1 year ago

Hi @vhemery, thanks for your PRs, I can take a look at both of them (and the build issue) tomorrow if that's early enough for you.

vhemery commented 1 year ago

There's absolutely no rush here. Take all the time you need.