Closed vhemery closed 2 years ago
@maho7791
BTW if we name the artifactId: org.eclipse.emfcloud.emfjson-jackson, this would change the BSN and the final jar without doin anything else :-)
That's one way of doing it. But the drawback is that it would change the maven publication. It would be best if we could keep all publications quite similar to before.
My doubts about the jar naming are probably not relevant though. Maybe just inserting Bundle-SymbolicName: ${project.groupId}.${project.artifactId}
is enough. This is the adopted solution I have seen elsewhere with bnd. But we'll have to wait and see how the P2 publishing reacts to this.
@martin-fleck-at I'll try and make a PR with just Bundle-SymbolicName: ${project.groupId}.${project.artifactId}
to see how P2 publishing reacts to this. Anyway, the result will be at least as good as the current master.
Following up conversation in https://github.com/eclipse-emfcloud/emfjson-jackson/issues/28
In version nightly/2.1/2.1.0.202203281247 , the plugin is no longer accessible by Eclipse's
Help > Install new software ...
menu for update site at https://download.eclipse.org/emfcloud/emfjson-jackson/p2/nightly/2.1/2.1.0.202203281247 (whereas it was at https://download.eclipse.org/emfcloud/emfjson-jackson/p2/nightly/2.1/2.1.0.202202160831 )When exploring the update site's content with browser or target platform definition DSL editor (https://github.com/eclipse-cbi/targetplatform-dsl ), we can find the plugin is present, but now with BSN emfjson-jackson when it used to be org.eclipse.emfcloud.emfjson-jackson.
Plugin for P2 usage should be named org.eclipse.emfcloud.emfjson-jackson as before, and accessible from Eclipse's update site menu for future versions.