search

eclipse-emfcloud / emfjson-jackson

emfjson-jackson
Other
16 stars 15 forks source link

Try and insert Bundle-SymbolicName for bnd #35

Closed vhemery closed 2 years ago

vhemery commented 2 years ago

Bnd has artifactId as default BSN, which differs from previous behavior. Try and tell BSN to bnd, hoping P2 update site publication will follow.

closes https://github.com/eclipse-emfcloud/emfjson-jackson/issues/34

martin-fleck-at commented 2 years ago

@vhemery Thank you very much! I had a look at this PR and to me it seems everything works as expected. I built an update site from it and the plugins seem to have the correct file name and show up in the update site as expected. Could you please double check whether this works for you as well?

New Update Site based on PR: https://download.eclipse.org/emfcloud/emfjson-jackson/p2/nightly/2.1/2.1.0.202205170805/ Prev Update Site based on master: https://download.eclipse.org/emfcloud/emfjson-jackson/p2/nightly/2.1/2.1.0.202203281247/ Prev Update Site (still working): https://download.eclipse.org/emfcloud/emfjson-jackson/p2/nightly/2.1/2.1.0.202202160831

Is there something else you want to add to this PR or can we remove the WIP then?

vhemery commented 2 years ago

WIP was only to wait and see. The new P2 publishing looks just fine to me.

I just reworded the commit message :

closes https://github.com/eclipse-emfcloud/emfjson-jackson/issues/34