search

eclipse-emfcloud / emfjson-jackson

emfjson-jackson
Other
16 stars 15 forks source link

Improve unknown feature diagnostic messages #39

Closed mdlnr closed 2 years ago

mdlnr commented 2 years ago

Solves #38

Message now includes current object EClass.

Example:

Unknown feature 'some_unknown_feature' for http://www.eclipse.org/emf/2002/Ecore#//EClass
vhemery commented 2 years ago

(you can amend the commit and force push to update the PR)

Oh... and by the way, if you could edit the commit message for adding closes https://github.com/eclipse-emfcloud/emfjson-jackson/issues/38 this would be perfect. Thank you. (see https://github.com/eclipse-emfcloud/emfjson-jackson/blob/master/CONTRIBUTING.md#branch-names-and-commit-messages )

mdlnr commented 2 years ago

Thanks for the feedback. Should look good now.

vhemery commented 2 years ago

Thank you very much @mdlnr for this feature. As I am quite new among committers, I am just checking with the rest of the team that I can directly process to the merge and that it doesn't conflict with the project's agenda. I or someone else in the team should merge this very soon.