search

eclipse-emfcloud / emfjson-jackson

emfjson-jackson
Other
17 stars 15 forks source link

EMFModule.Feature.OPTION_SERIALIZE_CONTAINMENT_AS_HREF does not have any effect #48

Closed juergen-albert closed 2 years ago

juergen-albert commented 2 years ago

The EMFModule can be configured with different Features and one of them is https://github.com/eclipse-emfcloud/emfjson-jackson/blob/e6bf66250b1a93045722864497d0233ffc521439/src/main/java/org/eclipse/emfcloud/jackson/module/EMFModule.java#L98

I've looked for the usage of the Feature and found none. Thus I assume it is not implemented for whatever reason. As far as I understand it, containment objects would be serialized as proxies. I'm not sure how this might produce a meaningful URI accept maybe for cross-document containments but this is besides the point. Does somebody know the intention behind this Feature and the question would be if it can be removed or if it would be forth it to implement it.

martin-fleck-at commented 2 years ago

That is a very good question! It seems that this option was originally introduced with 5 other options in the previous repository but only four of those options actually made it into the 1.0 release back then. Still, it seems to me that this option was never implemented and so far nobody has had any use for it. If you need it, we are happy to accept contributions but if you do not need it I would almost opt to remove that feature.

martin-fleck-at commented 2 years ago

@juergen-albert I'll remove the option for now. If you think it is valuable, please feel free to open a PR for it.

juergen-albert commented 2 years ago

Sorry for my late reply and thanks for your quick reaction. Removing it would have been my choice as well.