search

eclipse-equinox / equinox.bundles

Eclipse Public License 2.0
8 stars 16 forks source link

Unify read and write of EclipsePreferernces and general clean up #13

Closed HannesWell closed 2 years ago

HannesWell commented 2 years ago

A follow up of PR #8. Reading preferences does not require a dedicated InputStream class (I oversaw this in #8).

And apply miscellaneous clean-ups like avoiding unnecessary Array-creation or buffering of streams where it is not necessary.

This PR must not be merged before https://github.com/eclipse-platform/eclipse.platform.resources/pull/39 is merged, because this PR removes internally public static fields that were used in ProjectPreferences.

vogella commented 2 years ago

Looks fine to me.

Unrelated: I'm surprised that we still have code for loading 2.1 preference files, e.g. via protected void loadLegacy(). As we stopped supporting 2.x plug-ins a long time ago I think we should also be fine to remove the 2.1 preference support if someone cares enough to make the change.

HannesWell commented 2 years ago

Looks fine to me.

Thanks for reviewing it.

Unrelated: I'm surprised that we still have code for loading 2.1 preference files, e.g. via protected void loadLegacy(). As we stopped supporting 2.x plug-ins a long time ago I think we should also be fine to remove the 2.1 preference support if someone cares enough to make the change.

I cannot judge if this should be removed or not, this was before my time. But if it is really unnecessary it should be removed, but I think this should happen in a dedicated change.