search

eclipse-equinox / equinox.bundles

Eclipse Public License 2.0
8 stars 16 forks source link

Remove unused dependencies from Manifest.MF #19

Closed HannesWell closed 2 years ago

HannesWell commented 2 years ago

This also allows to re-enable org.eclipse.equinox.region.tests. Lets see if there are test failures to fix.

tjwatson commented 2 years ago

This also allows to re-enable org.eclipse.equinox.region.tests. Lets see if there are test failures to fix.

That will not work without aspectj bundles because of the JAR org.eclipse.equinox.region.tests/stubs/org.eclipse.virgo.teststubs.osgi.jar

I'm sure we can create custom proxies to do something here that is similar. I had this on my todo list long ago but never had time to dig in.

HannesWell commented 2 years ago

This also allows to re-enable org.eclipse.equinox.region.tests. Lets see if there are test failures to fix.

That will not work without aspectj bundles because of the JAR org.eclipse.equinox.region.tests/stubs/org.eclipse.virgo.teststubs.osgi.jar

Too bad. One of my motivations was to use Tycho-pomless for equinox-bundles too. We could then just build all projects in the bundles folder and would not have to list them one by one.

But while working on it I realized that this would benefit from some more preliminary work, mainly fixing warnings, which will be simpler once the osgi-sources are replaced by the Maven artifacts. Which brings me back to my initial task. Looking at the amount of changes in the pom I also think this PR would be better done after Tycho-pomless is used.

I'm sure we can create custom proxies to do something here that is similar. I had this on my todo list long ago but never had time to dig in.

Would you be fine to disable all failing tests for now so that the project can at least participate in the build?

With that being said I think it would be better to re-enable org.eclipse.equinox.region.tests in a separate change and to put this one on hold until equinox-bundles uses Tycho pomless.

HannesWell commented 2 years ago

We recently moved the repository content to https://github.com/eclipse-equinox/equinox would you be so kind to open your PR for the new repository?

I will just recreate this later, once some more other works is completed that make this change simpler.