Closed laeubi closed 2 years ago
@tjwatson can you review this?
FYI @vogella
Can we get a better commit messages? "Publish the a "BundleStateScope" as an IScopeContext service (factory)" is a great header but the commit message should contain a short description of the purpose of the change (focusing on the why). I assume most of this can be copied from the isssue.
If you like you can suggest a message to include, I found commit messages not very well suited to describe whats going on and have already described in the javadoc and issue the possible uses. Probably a N&N would be good as well if this is merged.
If you like you can suggest a message to include, I found commit messages not very well suited to describe whats going on and have already described in the javadoc and issue the possible uses. Probably a N&N would be good as well if this is merged.
The commit message is really useful for when browser the blame values in the IDE or otherwise for individual lines of code. So any additional hints there help the future contributors when they are looking at changes that may not be directly where you provided the javadoc.
by the way if you thing enabling declarative service for org.eclipse.equinox.preferences
is not desired I can think of using a plain service registration as it is not that complex to do it without DS here.
I updated the commit message just in case someone needs to "blame" the commit (I really like the EGit term "Show revision Information" much better...).
by the way if you thing enabling declarative service for
org.eclipse.equinox.preferences
is not desired I can think of using a plain service registration as it is not that complex to do it without DS here.
That may be for the best, but not because of the component.xml
confusion. Up until now the preferences
bundle has been able to run without a DS implementation.
by the way if you thing enabling declarative service for
org.eclipse.equinox.preferences
is not desired I can think of using a plain service registration as it is not that complex to do it without DS here.That may be for the best, but not because of the
component.xml
confusion. Up until now thepreferences
bundle has been able to run without a DS implementation.
Done.
LGTM
Would you kindly merge this then?
Would you kindly merge this then?
I mistakenly thought your committer election was already complete. Should be done this week I think. I did merge.
Fix https://github.com/eclipse-equinox/equinox.bundles/issues/24