Closed HannesWell closed 2 years ago
vogella
commented
2 years ago Deletion of copied or outdated code is IMHO a very important task which enables the Eclipse projects to evolve easier. Thanks @HannesWell for working on this big task in this and multiple other PRs.
HannesWell
commented
2 years ago Deletion of copied or outdated code is IMHO a very important task which enables the Eclipse projects to evolve easier. Thanks @HannesWell for working on this big task in this and multiple other PRs.
You're welcome. :) Totally agree, Eclipse itself is complex enough and there is no need to add extra layers if we don't have to.
Btw. this PR suffers the same problem like https://github.com/eclipse-equinox/equinox.framework/pull/44#issuecomment-1110660729
tjwatson
commented
2 years ago It seems we have two PRs for the same change. Isn't this nearly the same as PR eclipse-equinox/equinox.framework#26 ?
HannesWell
commented
2 years ago It seems we have two PRs for the same change. Isn't this nearly the same as PR eclipse-equinox/equinox.framework#26 ?
Nearly yes. This PR was consisting of the commit from PR eclipse-equinox/equinox.framework#26 and a second one to include the OSGi-bundles into features as it was reequested. I also included the commit of PR eclipse-equinox/equinox.framework#26 because the actual change of this PR is thematically build on top of the change of PR eclipse-equinox/equinox.framework#26. Once eclipse-equinox/equinox.framework#26 is merged that first commit would vanish. However in But in GitHub this does not work as nice as in Gerrit were I would get one change per commit. Since the changes are related in their topic but contain disjoint code-changes I force pushed this to contain only the commit to include the bundles into features.
HannesWell
commented
2 years ago Since it looks like the associated changes in the plug-ins to replace the osgi-bundles will be submitted at different point of time and the next M2 happens soon I think the replacing OSGi-bundles should be included into features ASAP. Therefore I have split this PR into multiples where each PR includes those OSGi-bundles that are now referenced by the plug-ins changed in the associated 'Plug-in change'-PR. This also simplifies the review process because the change is smaller.
So this PR is superseded by:
This PR adds the OSGi-bundles from Maven-Central that replace the formerly embedded OSGi source-code to those Features that contain the Plug-ins whose OSGi-sources are replaced. The motivation to add the OSGi-bundles to the features is mainly to also have their sources included into the p2-repos of the Eclipse-SDK.
This is part of https://github.com/eclipse-equinox/equinox/issues/18 and should be submitted after https://github.com/eclipse-equinox/equinox.framework/pull/41, https://github.com/eclipse-equinox/equinox.framework/pull/44 and https://github.com/eclipse-equinox/equinox.bundles/pull/26 are merged.