search

eclipse-equinox / equinox.bundles

Eclipse Public License 2.0
8 stars 16 forks source link

Simply server.p2 feature by including p2.core feature #40

Closed HannesWell closed 2 years ago

HannesWell commented 2 years ago

Including o.e.equinox.p2.core.feature in the o.e.equinox.server.p2 feature simplifies the latter a lot.

This change would effectively add the following plug-ins to o.e.equinox.server.p2:

But since those plug-ins are listed at the very end of p2.core I wonder if server.p2 was initially intended to contain everything in p2.core and was not updated to contain those plug-ins that are effectively added with this change.

HannesWell commented 2 years ago

Since the o.e.equinox.p2.core.feature feature contains many p2 bundles I wonder if it would be more suitable to move it into the p2 repo. AFAICT equinox.bundles only depends in this feature on p2, so moving it to p2 would create a clear dependency from p2 to equinox(.bundles) without any edge back.

Since p2 and equinox.bundles are build/published together I think there is no API problem with that. @akurtakov, @mickaelistria @tjwatson what do you think (about this change and the suggestion to move it)?

akurtakov commented 2 years ago

Yes, please! Move it to p2 repo, that would even make the version bump check to detect proper as this is one of the bundles we always find to need version bump through inspecting build log as verification builds don't catch it because of the cross-repo boundary.

akurtakov commented 2 years ago

And regarding the patch itself - it totally makes sense for server feature to depend on core. Please merge once ready.

mickaelistria commented 2 years ago

Please apply this change as soon as it's ready, and then it's good thing to move it to p2.

HannesWell commented 2 years ago

Great. But I think it is better to move the feature first and to re-create this PR in the P2 repo (there are specific build-qualifier problems again, that hopefully vanish in the p2 repo). The PRs are:

So I'm closing this one here.