search

eclipse-equinox / equinox

equinox
Eclipse Public License 2.0
28 stars 60 forks source link

Remove unused leftovers of WPF launcher in JNIBridge #624

Closed HannesWell closed 1 month ago

HannesWell commented 1 month ago

For the equinox launcher for Windows WPF launcher the native methods OleInitialize() and OleUninitialize() where introduced that where only implemented in the native library available for Windows WPF, see Bug 172367 / 3cf8518912fb064f582a5fa3b7ef020b2155e1b6. But during the removal of the WPF launcher in Bug 479180 / 121b7c5b2cb5f7a130720d382a3eac8c0e290a05 these methods have not been removed.

Since the native implementation is not available anymore these native methods cannot be used.

github-actions[bot] commented 1 month ago

Test Results

  660 files  ±0    660 suites  ±0   1h 12m 44s :stopwatch: -7s 2 195 tests ±0  2 148 :white_check_mark: ±0   47 :zzz: ±0  0 :x: ±0  6 729 runs  ±0  6 586 :white_check_mark: ±0  143 :zzz: ±0  0 :x: ±0 

Results for commit 6001d53e. ± Comparison against base commit fadf6d11.

:recycle: This comment has been updated with latest results.