search

eclipse-equinox / equinox

equinox
Eclipse Public License 2.0
31 stars 65 forks source link

[Build] Assume new equinox.binaries repo name by default in scripts #641

Closed HannesWell closed 3 months ago

HannesWell commented 3 months ago

Because the repository containing the Equinox binaries is now named 'eclipse-equinox/equinox.binaries' its folder is, by default, named 'equinox.binaries' after cloning it. In order to simplify contributions that name should be assumed by default.

Accordingly rename the property 'rt.equinox.binaries.loc' used in the build to 'equinox.binaries.loc'.

@tjwatson do you have any objections?

github-actions[bot] commented 3 months ago

Test Results

  660 files  ±0    660 suites  ±0   1h 12m 9s :stopwatch: +23s 2 195 tests ±0  2 148 :white_check_mark: ±0   47 :zzz: ±0  0 :x: ±0  6 729 runs  ±0  6 586 :white_check_mark: ±0  143 :zzz: ±0  0 :x: ±0 

Results for commit f50795ca. ± Comparison against base commit 343e816e.

:recycle: This comment has been updated with latest results.

laeubi commented 3 months ago

Launcher test now fail

Supplied equinox binaries location does not exist: D:\a\equinox\equinox\rt.equinox.binaries
java.lang.IllegalArgumentException: Supplied equinox binaries location does not exist: D:\a\equinox\equinox\rt.equinox.binaries
    at org.eclipse.equinox.launcher.tests.LauncherTests.prepareLauncherSetup(LauncherTests.java:93)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
HannesWell commented 3 months ago

When this is submitted we should also adapt the paths in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81db9931a45fdbae03b9128f3cd30a791749d831/.gitmodules#L29-L31

and all other references the releng.aggregator repository.

HannesWell commented 3 months ago

When this is submitted we should also adapt the paths in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81db9931a45fdbae03b9128f3cd30a791749d831/.gitmodules#L29-L31

and all other references the releng.aggregator repository.

This is now done with https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2128.

HannesWell commented 3 months ago

Finally the build is green (besides the usual TCK failure), so lets submit this.