search

eclipse-equinox / equinox

equinox
Eclipse Public License 2.0
31 stars 65 forks source link

Fix module-info private packages for about_files #644

Closed tjwatson closed 3 months ago

tjwatson commented 3 months ago

The framework org.eclipse.osgi cannot be used with jlink because the module-info is not including the about_files directory in its list of private content for the module.

The generation of the module-info from BND is not including this folder because it is only included as a root resource in the bundle at packaging time from the build.properties.

This change moves the about_files folder into a source folder so that it is included in the root of the bundle just like any other resources from the compiled source folders. This allows BND to see the resource and generate the module-info class correctly.

github-actions[bot] commented 3 months ago

Test Results

  660 files  ±0    660 suites  ±0   1h 12m 53s :stopwatch: + 1m 38s 2 195 tests ±0  2 148 :white_check_mark: ±0   47 :zzz: ±0  0 :x: ±0  6 729 runs  ±0  6 586 :white_check_mark: ±0  143 :zzz: ±0  0 :x: ±0 

Results for commit 80af2fa4. ± Comparison against base commit b5d24533.