eclipse-equinox / equinox

equinox
Eclipse Public License 2.0
28 stars 60 forks source link

Fix BasicLocation set method when read-only and lock requested #646

Closed tjwatson closed 2 weeks ago

tjwatson commented 2 weeks ago

https://github.com/eclipse-equinox/equinox.framework/pull/39 PR introduced a breaking change that always returned true with a read-only location and lock was requested to the set method.

The testCreateLocation04 method also needed fixing to properly test this case.

Fixes #460

github-actions[bot] commented 2 weeks ago

Test Results

  660 files  ±0    660 suites  ±0   1h 14m 8s :stopwatch: + 1m 46s 2 195 tests ±0  2 148 :white_check_mark: ±0   47 :zzz: ±0  0 :x: ±0  6 729 runs  ±0  6 586 :white_check_mark: ±0  143 :zzz: ±0  0 :x: ±0 

Results for commit 431bcd65. ± Comparison against base commit c8ce7365.