Replace "UTF8" with StandardCharsets.UTF_8

eclipse-equinox / equinox

equinox

Eclipse Public License 2.0

28 stars 60 forks source link

Replace "UTF8" with StandardCharsets.UTF_8 #651

Closed jukzi closed 3 days ago

jukzi commented 3 days ago

Avoids NON-NLS and possible UnsupportedEncodingException

github-actions[bot] commented 3 days ago

Test Results

660 files ±0 660 suites ±0 1h 14m 3s :stopwatch: -13s 2 195 tests ±0 2 148 :white_check_mark: ±0 47 :zzz: ±0 0 :x: ±0 6 729 runs ±0 6 586 :white_check_mark: ±0 143 :zzz: ±0 0 :x: ±0

Results for commit b1776a07. ± Comparison against base commit d47753c3.

:recycle: This comment has been updated with latest results.

jukzi commented 3 days ago

Unfortunately java.io.ByteArrayOutputStream.toString(Charset) requires JDK 10 and this project is stuck to 1.8 :-(

jukzi commented 3 days ago

ignoring unrelated tck fails