eclipse-equinox / equinox

equinox
Eclipse Public License 2.0
33 stars 66 forks source link

org.eclipse.core.internal.net.Activator fails to start with missing passwordprovider #99

Closed laeubi closed 1 year ago

laeubi commented 2 years ago
org.eclipse.equinox.security.storage.StorageException: Unable to locate secure storage module (org.eclipse.tycho.noopsecurity.id1).
    at org.eclipse.equinox.internal.security.storage.PasswordProviderSelector.findStorageModule(PasswordProviderSelector.java:211)
    at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:237)
    at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:230)
    at org.eclipse.equinox.internal.security.storage.SecurePreferences.get(SecurePreferences.java:267)
    at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.get(SecurePreferencesWrapper.java:123)
    at org.eclipse.core.internal.net.ProxyType.loadProxyAuth(ProxyType.java:559)
    at org.eclipse.core.internal.net.ProxyType.createProxyData(ProxyType.java:145)
    at org.eclipse.core.internal.net.ProxyType.getProxyData(ProxyType.java:134)
    at org.eclipse.core.internal.net.ProxyType.initialize(ProxyType.java:539)
    at org.eclipse.core.internal.net.ProxyManager.initialize(ProxyManager.java:262)
    at org.eclipse.core.internal.net.Activator.start(Activator.java:177)

Instead it should simply handle this as if there is no password available!

laeubi commented 2 years ago

Actually this is only printed as an error, but the code just goes on, this is very bad as it leaves the user with the feeling something goes wrong....

github-actions[bot] commented 1 year ago

This issue has been inactive for 180 days and is therefore labeled as stale. If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below. Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.