search

eclipse-equinox / p2

Eclipse Public License 2.0
15 stars 41 forks source link

Allow to pass an agent at the constructor for publisher applications #390

Closed laeubi closed 10 months ago

laeubi commented 10 months ago

Currently the agent is always determined implicitly by query the service registry, even though one can extend the application and the overwrite setupAgent it seems much more suitable to offer a way to set the agent at construction time.

@merks this should be transparent for existing code but just in case you maybe can have a deeper look at this.

I noticed that the lack of constructor is one reason Tycho currently uses some workaround or extends applications and so other might do as well, adding a suitable constructor seems not really harm or defeat any purpose, the default i just for the use cases where the application is used at the extension points that can't pass constructor argument easily.

github-actions[bot] commented 10 months ago

Test Results

       9 files  ±0         9 suites  ±0   29m 58s :stopwatch: -13s 2 181 tests ±0  2 177 :heavy_check_mark: ±0    4 :zzz: ±0  0 :x: ±0  6 633 runs  ±0  6 622 :heavy_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit 77605664. ± Comparison against base commit 18ba0359.