search

eclipse-equinox / p2

Eclipse Public License 2.0
15 stars 41 forks source link

Remove @noreference from InstallableUnit.isSingleton/getFilter #402

Closed merks closed 10 months ago

github-actions[bot] commented 10 months ago

Test Results

       9 files  ±0         9 suites  ±0   31m 50s :stopwatch: + 2m 23s 2 181 tests ±0  2 177 :heavy_check_mark: ±0    4 :zzz: ±0  0 :x: ±0  6 633 runs  ±0  6 622 :heavy_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit 913e16bc. ± Comparison against base commit cb70b67c.

merks commented 10 months ago

Guys, do you have any concerns about this? There are downstream warnings that will be fixed and in the end, one can't really do useful things with p2 without taking this information into account, especially the getFilter information, that's needed here:

https://github.com/eclipse-tycho/tycho/issues/3197

Oomph and the CBI Aggregator need it to, so it's kind of silly how it is now.