search

eclipse-equinox / p2

Eclipse Public License 2.0
15 stars 41 forks source link

remove Exceptions not actually thrown #434

Closed jukzi closed 9 months ago

jukzi commented 9 months ago

eliminates problem markers and dead code

github-actions[bot] commented 9 months ago

Test Results

    9 files  ±0      9 suites  ±0   29m 52s :stopwatch: +27s 2 183 tests ±0  2 179 :white_check_mark: ±0   4 :zzz: ±0  0 :x: ±0  6 639 runs  ±0  6 628 :white_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit 3710db65. ± Comparison against base commit 24d98b90.

:recycle: This comment has been updated with latest results.

jukzi commented 9 months ago

review/ submit any committer, please?

merks commented 9 months ago

@jukzi Such removals are only acceptable assuming no one has overridden the method, right?

jukzi commented 9 months ago

@jukzi Such removals are only acceptable assuming no one has overridden the method, right?

yes. if someone in my workspace had overriden it it would have been resulted in an error. As private packages they should not be used outside.

jukzi commented 9 months ago

thanks, ed