search

eclipse-equinox / p2

Eclipse Public License 2.0
15 stars 41 forks source link

set UTF-8 encoding #441

Closed jukzi closed 9 months ago

jukzi commented 9 months ago

solves "Project '' has no explicit encoding set"

github-actions[bot] commented 9 months ago

Test Results

    9 files  ±0      9 suites  ±0   30m 11s :stopwatch: - 3m 54s 2 183 tests ±0  2 179 :white_check_mark: ±0   4 :zzz: ±0  0 :x: ±0  6 639 runs  ±0  6 628 :white_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit 344bec0d. ± Comparison against base commit 36fd2c42.

:recycle: This comment has been updated with latest results.

merks commented 9 months ago

@laeubi @jukzi

It seems pretty much everything is failing. Some do appear to be related, e.g., this is probably because the jgit stamp changes but there are no other changes:

Error:  Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.5:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.equinox.p2.garbagecollector: Only qualifier changed for (org.eclipse.equinox.p2.garbagecollector/1.3.100.v20240131-1530). Expected to have bigger x.y.z than what is available in baseline (1.3.100.v20230630-1506) -> [Help 1]

The javadoc looks to be in pretty bad shape. 😱

https://ci.eclipse.org/equinox/job/p2/job/PR-441/1/console

But even here, the overall failures are from baseline comparison problems that @jukzi will need to fix...

merks commented 9 months ago

Was it intentional that you added a commit rather than amending and force pushing?

jukzi commented 9 months ago

Was it intentional that you added a commit rather than amending and force pushing?

yes, some people prefer to have version bump in separate commit to make revert easier.

jukzi commented 9 months ago

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-director-plugin:4.0.5:archive-products (archive-products) on project org.eclipse.equinox.p2.reconciler: Error packing product: Problem creating zip: Execution exception: Java heap space -> [Help 1]

without commit rights i can not restart jenkins job

merks commented 9 months ago

I can kick it, but sometimes for projects where I cannot, I just force push a tiny change to the commit comment.

merks commented 9 months ago

It was just some failure at the end packaging something that we don't need for anything.