search

eclipse-equinox / p2

Eclipse Public License 2.0
14 stars 40 forks source link

Add optional, greedy and disabled by default requirement to the source #446

Closed laeubi closed 7 months ago

laeubi commented 7 months ago

Currently it is quite cumbersome effort to include the source of a bundle with an installation even though there might be multiple demands, for example legal reasons or debugging.

This now adds a new greedy, optional requirement that is disabled by a filter so it is not effective by default but enables an install agent to specify a property of org.eclipse.equinox.p2.includesource=true to include sources of bundles in products whenever available.

github-actions[bot] commented 7 months ago

Test Results

    9 files  ±0      9 suites  ±0   32m 44s :stopwatch: + 2m 14s 2 183 tests ±0  2 179 :white_check_mark: ±0   4 :zzz: ±0  0 :x: ±0  6 639 runs  ±0  6 628 :white_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit a6451e37. ± Comparison against base commit 7ced2010.

:recycle: This comment has been updated with latest results.

HannesWell commented 7 months ago

Sounds also reasonable for me as well. Would it make sense to have a constant for the filter so that code enabling it can reference the constant?

laeubi commented 7 months ago

I now tested this and in general it works with Tycho but just requires some additional configuration at the moment, I also take the opportunity to fix javadoc errors and extract some constants here, so now this should be ready to submit.