eclipse-equinox / p2

Eclipse Public License 2.0
14 stars 40 forks source link

Ensure the product *.ini is loaded and saved using the native encoding #482

Closed merks closed 6 months ago

merks commented 6 months ago

The native launcher executable reads the product .ini, e.g., eclipse.ini, using the native system encoding. Currently the .ini is loaded and saved in the launched Java application using the system default encoding, but in Java 21 the default encoding is always UTF-8 so we need to be more careful to always use the native encoding regardless of the default encoding.

github-actions[bot] commented 6 months ago

Test Results

    9 files  ±0      9 suites  ±0   30m 12s :stopwatch: +48s 2 184 tests ±0  2 180 :white_check_mark: ±0   4 :zzz: ±0  0 :x: ±0  6 642 runs  ±0  6 631 :white_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit c509bff7. ± Comparison against base commit 041c27e4.

:recycle: This comment has been updated with latest results.