search

eclipse-equinox / p2

Eclipse Public License 2.0
14 stars 39 forks source link

VersionRange for root features is too tight when expanded version given #507

Closed laeubi closed 3 months ago

laeubi commented 3 months ago

Currently the (disabled by default) requirement for a root feature uses an exact version range when the feature version is expanded (e.g. Tycho) but the purpose of a root feature is that it can be updated what such a strict range makes it impossible (if activated).

This now adds a new IVersionRangeAdvice that allows to modify the result of a product included requirements version range.

github-actions[bot] commented 3 months ago

Test Results

    9 files  ±0      9 suites  ±0   29m 47s :stopwatch: -30s 2 196 tests ±0  2 192 :white_check_mark: ±0   4 :zzz: ±0  0 :x: ±0  6 678 runs  ±0  6 667 :white_check_mark: ±0  11 :zzz: ±0  0 :x: ±0 

Results for commit 0424619b. ± Comparison against base commit 4426f86e.

:recycle: This comment has been updated with latest results.

laeubi commented 3 months ago

I think the best would be if one can configure it in the product editor like it is possible with feature dependencies, this would probably be even better than the current "root feature" approach. But that's more for a future enhancement.