Closed merks closed 3 months ago
github-actions[bot]
commented
3 months ago 250 files - 125 250 suites - 125 27m 25s :stopwatch: - 15m 27s 1 893 tests ± 0 1 890 :white_check_mark: ± 0 3 :zzz: ±0 0 :x: ±0 4 451 runs - 2 228 4 445 :white_check_mark: - 2 225 6 :zzz: - 3 0 :x: ±0
Results for commit 43392e45. ± Comparison against base commit b46100f4.
:recycle: This comment has been updated with latest results.
merks
commented
3 months ago I won't have time for further changes after my 13 hour day. If you feel they are necessary, you or someone else will need to make such changes. Sorry.
iloveeclipse
commented
3 months ago I won't have time for further changes after my 13 hour day.
You shouldn't push a PR after 8 hours day in the first place :-)
If you feel they are necessary
Yes, otherwise we may run into issues if people get "partial" p2 updates.
I've updated your patch with required changes.
iloveeclipse
commented
3 months ago Interesting (and unrelated) error on Mac
Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8-SNAPSHOT:verify (verify) on project org.eclipse.equinox.p2.discovery:
Execute ApiApplication failed: InvocationTargetException:
Cannot load from object array because "this.this$0.fIndexedDetectors" is null -> [Help 1]Shouldn't be the problem caused by this PR.
iloveeclipse
commented
3 months ago Something is wrong with API tooling:
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8-SNAPSHOT:verify (verify) on project org.eclipse.equinox.p2.reconciler.dropins: Execute ApiApplication failed: InvocationTargetException: Error reading manifest for /home/jenkins/agent/workspace/p2_PR-516/.m2/repository/p2/osgi/bundle/org.sat4j.pb.source/2.3.6.v20201214/org.sat4j.pb.source-2.3.6.v20201214.jar: zip file is empty
Fixes https://github.com/eclipse-equinox/p2/issues/514