search

eclipse-equinox / p2

Eclipse Public License 2.0
14 stars 39 forks source link

Always use full-named o.e.equinox.launcher artifact #519

Closed HannesWell closed 3 months ago

HannesWell commented 3 months ago

For for Mac OS X there was no equinox-launcher fragment for CARBON with full name, i.e. with .. suffix, but only a org.eclipse.equinox.launcher.carbon.macosx fragment. But since Eclipse 4.2, released 2012, CARBON is not supported anymore at all [1]. Therefore the code adjust to that special naming schema, which also imposed difficulties or new supported architectures on Macos should be removed.

See also https://github.com/eclipse-equinox/equinox/pull/622

[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400

HannesWell commented 3 months ago

@merks, @laeubi do you think this is something we should have for the upcoming summer release? This would then probably allow us to remove the short-named launcher fragment for mac (see https://github.com/eclipse-equinox/equinox/pull/622). But I would leave the actual removal for the next release-cycle.

github-actions[bot] commented 3 months ago

Test Results

  251 files  + 1    251 suites  +1   28m 39s :stopwatch: - 1m 9s 1 887 tests ± 0  1 884 :white_check_mark: ± 0  3 :zzz: ±0  0 :x: ±0  4 482 runs  +26  4 476 :white_check_mark: +26  6 :zzz: ±0  0 :x: ±0 

Results for commit b25e3a71. ± Comparison against base commit 5073d13e.

:recycle: This comment has been updated with latest results.

HannesWell commented 3 months ago

So indeed it seems better to fix it sooner rather than later.

Agree.

As a result, when you get rid if it, everyone building products against the latest platform builds must use a new release to Tycho, or their builds will fail, right?

That's right. But I think in general it's hard to expect/ensure that old tools work with new content because we can't predict the future. For example PDE warns if the TP content is newer than the runtime. But to have at least a three-months transition period I think it would be best to have this in now and remove the short-named launcher fragment for the next release.

This logic is used primarily by Tycho so when Tycho starts using the new version then you can get rid of the older short name.

For the record, here is the pendant in https://github.com/eclipse-tycho/tycho/pull/3860. I have to admit that I'm not absolutely sure which change will be the one that influence the product assemble, but I assume its this one.