Prevent NPE when no artifact repository is given

eclipse-equinox / p2

Eclipse Public License 2.0

14 stars 39 forks source link

Prevent NPE when no artifact repository is given #524

Open laeubi opened 2 months ago

laeubi commented 2 months ago

Currently RawMirrorRequest can fail if no repository is given in the descriptor and it want to log a message.

P2 should be gracefully in this case and simply report the location as being unknown.

github-actions[bot] commented 2 months ago

Test Results

375 files ±0 375 suites ±0 43m 54s :stopwatch: + 2m 29s 1 893 tests ±0 1 890 :white_check_mark: ±0 3 :zzz: ±0 0 :x: ±0 6 679 runs ±0 6 670 :white_check_mark: ±0 9 :zzz: ±0 0 :x: ±0

Results for commit c0131e95. ± Comparison against base commit 2d7670ba.

:recycle: This comment has been updated with latest results.

merks commented 2 months ago

Of course the usual version bump games kick in...

laeubi commented 1 month ago

@merks sorry for the delay, yes it seems soem version bumps are still required.

laeubi commented 1 month ago

@merks actually it is "Error reading manifest for /home/jenkins/agent/workspace/p2_PR-524/.m2/repository/p2/osgi/bundle/bcprov.source/1.78.1/bcprov.source-1.78.1.jar" again not a version bump problem, so I'll rebase...