search

eclipse-equinox / p2

Eclipse Public License 2.0
14 stars 39 forks source link

remove unnecessary casts #527

Closed stephan-herrmann closed 2 months ago

stephan-herrmann commented 2 months ago

When https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2471 is merged, ecj will signal more casts as unnecessary.

With this PR I suggest to remove affected casts before new warnings will show up in the build.

github-actions[bot] commented 2 months ago

Test Results

  375 files  ±0    375 suites  ±0   45m 6s :stopwatch: -24s 1 893 tests ±0  1 890 :white_check_mark: ±0  3 :zzz: ±0  0 :x: ±0  6 679 runs  ±0  6 670 :white_check_mark: ±0  9 :zzz: ±0  0 :x: ±0 

Results for commit f7ba2ec3. ± Comparison against base commit b76734f6.

:recycle: This comment has been updated with latest results.

stephan-herrmann commented 2 months ago

10 successful and 1 failing checks

how does this fit to a list of only successful checks, nevermind I found the scrollbar

and btw how does this correspond to the "Checks" tab above saying "9". That tab indeed shows no failure...

stephan-herrmann commented 2 months ago

AutomatedTests org.eclipse.equinox.p2.tests.artifact.repository.AllTests.testSimpleRepositoryPerformanceOnLoadReadonlyLocalRepository (from AutomatedTests org.eclipse.equinox.p2.tests.artifact.repository.AllTests org.eclipse.equinox.p2.tests.artifact.repository.FoldersRepositoryTest) :

Querying artifact key from simple repository has performance issue. expected:<1.0> but was:<16.0>

should I worry, or can someone simply retrigger the build?

merks commented 2 months ago

Probably a slow build executor. Don’t worry about it.

merks commented 2 months ago

I think there are version problems still

plugin:4.0.8:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.equinox.p2.ui.importexport: Only qualifier changed for (org.eclipse.equinox.p2.ui.importexport/1.4.400.v20240620-1753). Expected to have bigger x.y.z than what is available in baseline (1.4.400.v20240321-1450) -> [Help 1]

stephan-herrmann commented 2 months ago

This error looks new:

15:20:37  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8:verify (verify) on project org.eclipse.equinox.p2.reconciler.dropins: Execute ApiApplication failed: InvocationTargetException: Error reading manifest for /home/jenkins/agent/workspace/p2_PR-527/.m2/repository/p2/osgi/bundle/bcprov.source/1.78.1/bcprov.source-1.78.1.jar: zip file is empty -> [Help 1]
stephan-herrmann commented 2 months ago

does anybody have a clue how bcprov.source-1.78.1.jar is relevant for the build and/or what could have broken it (in the local maven repo, i.e.)?

laeubi commented 2 months ago

@stephan-herrmann see:

stephan-herrmann commented 2 months ago

@stephan-herrmann see:

* [BundleComponent.isValidBundle() should no throw if reading manifest fail eclipse-pde/eclipse.pde#1303](https://github.com/eclipse-pde/eclipse.pde/pull/1303)

Wow, so we need to wait for PDE which waits for a license check (for what?) until p2 can again build cleanly?

Should all this block the merge in JDT, or is it acceptable that p2 will see a few new warnings regarding unnecessary casts (I don't recall right now if they were reported as warning or error)?

laeubi commented 2 months ago

Sometimes it works some time later when the Network is not flaky anymore or one can trust the three successful runs on Github Actions and the committer to have it checked in the IDE :-)

akurtakov commented 2 months ago

Let's merge this one. The changes looks good and some builds succeed so I'll call this PR "validated"

stephan-herrmann commented 2 months ago

Let's merge this one. The changes looks good and some builds succeed so I'll call this PR "validated"

thanks a lot!