search

eclipse-esmf / esmf-antora-ui

Offer Antora UI components to publish documentation
https://eclipse-esmf.github.io/esmf-documentation/index.html
Mozilla Public License 2.0
0 stars 4 forks source link

Hardcoded URLs break local builds #16

Open atextor opened 9 months ago

atextor commented 9 months ago

In the new UI, in particular in the dropdowns, there are many URLs hardcoded with "http://eclipse-esmf.github.io/..." instead of using relative links. This means those menus do not work as intended when doing a local build using a site-local.yml.

aniluede commented 6 months ago

As for the dropdowns of the top navigation: the links indeed are hardcoded as they are defined in the corresponding HBS source file of the UI Bundle the page uses for its layout. Referring to these files:

I don't see how the links there could be XREFs.

However, the tiles of the landing page -- which are defined here: https://github.com/eclipse-esmf/eclipse-esmf.github.io/blob/main/documentation/modules/ROOT/pages/index.adoc?plain=1 -- do hold relative links. They can be used to jump around in local builds.

And also, in the index.adoc file linked above -- at the moment we introduce HTML, for example to specify a button, we are back to hardcoded URLs instead of XREFs.

--

Proposing to close this issue as "Won't fix".