search

eclipse-esmf / esmf-aspect-model-editor

Manage Aspect Models visually — create, validate, create artefacts, persist file based
https://eclipse-esmf.github.io/ame-guide/introduction.html
Mozilla Public License 2.0
21 stars 7 forks source link

[TASK] Copyright header disappears after Save to Workspace #219

Open KobOp opened 4 months ago

KobOp commented 4 months ago

How: List of performed steps

  1. Open a model with a copyright header on AME
  2. Make changes to the model
  3. Select Save to Workspace
  4. Open the saved file in a text editor

What: Actual result vs expected result Actual behavior: The copyright text disappeared Expected: The copyright text should persist

Where: (e.g. component, version, url, your system info) AME Windows AME version: 5.5.0 SAMM version: 2.1.0 ESMF SDK version: 2.7.0

Input (files/screenshots) Common.txt (please change to .ttl, since .ttl is not supported in github)

Output (files/screenshots)

Additional context (e.g. references) The copyright header persists when the model is exported.

chris-volk commented 4 months ago

This is a missing feature, thanks for pointing out. We're aware of and already working on it, with https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/pull/301/ we have defined the representation of copyrigh&license in a header, see https://github.com/bci-oss/esmf-semantic-aspect-meta-model/blob/5bbf91a27731e75088aee39174e91a1029682e52/documentation/decisions/0008-copyright-and-license-information.md . This will be implemented in the java SDK and the Aspect Model Editor next.