eclipse-esmf / esmf-sdk-py-aspect-model-loader

Load Aspect Models in Python
https://pypi.org/project/esmf-aspect-model-loader/
Mozilla Public License 2.0
0 stars 4 forks source link

#43 state initiator implementation #45

Closed thec0dewriter closed 3 weeks ago

thec0dewriter commented 3 months ago

Description

added a first implementation mainly based on the Enum implementation, given it's an enum with a default value. Maybe a better option would be to reuse the enum implementation

Fixes #43

Type of change

Please delete options that are not relevant.

Checklist:

Additional notes:

Add any other notes or comments here.

thec0dewriter commented 3 months ago

Hi @atextor, Fixed the Eclipse Contributor check

Hanna-Shalamitskaya-EPAM commented 1 month ago

@thec0dewriter please have a look at comments to your PR

Looking forward for your changes

thec0dewriter commented 3 weeks ago

Thanks @Hanna-Shalamitskaya-EPAM for the detailed feedback. I made the suggested modifications, let me know if I missed something

atextor commented 3 weeks ago

Thank you for your contribution @thec0dewriter!

Hanna-Shalamitskaya-EPAM commented 2 weeks ago

@thec0dewriter, thank you for your contribution