search

eclipse-esmf / esmf-sdk

Load Aspect Models and their artifacts as Java code; share components to realize SAMM as code
https://eclipse-esmf.github.io/esmf-developer-guide/index.html
Mozilla Public License 2.0
25 stars 12 forks source link

[BUG] Using AspectModelValidator fails to validate models with Point3d #311

Closed external-Bogdan-Toma closed 1 year ago

external-Bogdan-Toma commented 1 year ago

Describe the bug Using AspectModelValidator fails to validate models with bamm-e:Point3d. Having 2 model elements in different namespaces extending bamm-e:Point3d with properties having same name fails to validate.

Violations messages: The Entity ':Point3dWithLabelEntity' contains Property 'label' which causes ambiguity in combination with the 'urn:bamm:com.example.point3d1:0.0.1#Point3dWithLabelEntity' Entity., The Entity 'urn:bamm:com.example.point3d1:0.0.1#Point3dWithLabelEntity' contains Property 'label' which causes ambiguity in combination with the ':Point3dWithLabelEntity' Entity.

Where sds-aspect-model-validator version 2.1.3.

Additional context Attached zip with tests and models. org.example.validation.test.zip Use test class: org.example.ValidationTest.

RaMisess commented 1 year ago

The validation of extension scenarios like this has been relaxed for https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/issues/161, this should fix this issue as well.

atextor commented 1 year ago

Issue has been fixed with the adoption of SAMM 2.1.0, which includes the fix for https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/issues/161.