eclipse-esmf / esmf-sdk

Load Aspect Models and their artifacts as Java code; share components to realize SAMM as code
https://eclipse-esmf.github.io/esmf-developer-guide/index.html
Mozilla Public License 2.0
25 stars 12 forks source link

[BUG] PNG Generator produces wrong output if Model Elements from other aspects are imported #383

Open bs-jokri opened 1 year ago

bs-jokri commented 1 year ago

Describe the bug Call PNG generator by

 java -jar samm-cli-2.2.2.jar  aspect io.catenax.id_based_request_for_update/1.0.0/IdBasedRequestForUpdate.ttl to png -o output.png

for a model with a property imported from another namespace.

Instead of the aspect of the importing model (IdBasedRequestForUpdate.ttl), the aspect of the imported model is shown.

removing the aspect definition from the imported model, forces the generator to use the correct aspect.

Also it generates a dependency between property and characteristic twice, even though there is only one. image

Model and files can be provided upon request.

bs-jokri commented 1 year ago

you can find the model in this PR https://github.com/eclipse-tractusx/sldt-semantic-models/pull/160/files

You should check out the whole repository, to have the imported model available as well. from the root folder of the repo you can call

 java -jar samm-cli-2.2.2.jar  aspect io.catenax.id_based_request_for_update/1.0.0/IdBasedRequestForUpdate.ttl to png -o output.png

which should produce the mentioned problem

atextor commented 1 year ago

@bs-jokri The PR model does not seem to contain a header Property or a HeaderCharacteristic. Can you please point to a place that reproduces the problem?

ysrbo commented 8 months ago

The issue was fixed in samm-cli v.2.4.0 https://github.com/eclipse-esmf/esmf-sdk/pull/407