eclipse-esmf / esmf-sdk

Load Aspect Models and their artifacts as Java code; share components to realize SAMM as code
https://eclipse-esmf.github.io/esmf-developer-guide/index.html
Mozilla Public License 2.0
25 stars 12 forks source link

[BUG] SDK CLI AAS XML - id_defaultAdminShell non-conformant to AAS Spec. #524

Closed BirgitBoss closed 9 months ago

BirgitBoss commented 9 months ago

How: List of performed steps

Bugs and was expected instead:

Looks like this:

<assetAdministrationShell>
      <id>https://admin-shell-io/aas/1/1/11F5398C55KQFUZ</id>
      <assetInformation>
        <assetKind>Instance</assetKind>
      </assetInformation>
      <submodels>
        <reference>
          <type>ModelReference</type>
          <keys>
            <key>
              <type>Submodel</type>
              <value>urn:samm:io.catenax.battery.battery_pass:4.0.0#BatteryPass</value>
            </key>
          </keys>
        </reference>
      </submodels>
    </assetAdministrationShell>

This is how it currently looks like:


<aas:assetAdministrationShell>
      <aas:idShort>id_defaultAdminShell</aas:idShort>
      <aas:description>
        <aas:langStringTextType>
          <aas:language>en</aas:language>
          <aas:text>defaultAdminShell</aas:text>
        </aas:langStringTextType>
      </aas:description>
      <aas:administration/>
      <aas:id>urn:samm:io.catenax.battery.battery_pass:4.0.0#BatteryPass</aas:id>
      <aas:embeddedDataSpecifications>
        <aas:embeddedDataSpecification>
          <aas:dataSpecification>
            <aas:type>ExternalReference</aas:type>
            <aas:keys>
              <aas:key>
                <aas:type>GlobalReference</aas:type>
                <aas:value>Optional[urn:samm:io.catenax.battery.battery_pass:4.0.0#BatteryPass]</aas:value>
              </aas:key>
            </aas:keys>
          </aas:dataSpecification>
          <aas:dataSpecificationContent>
            <aas:dataSpecificationIec61360>
              <aas:preferredName>
                <aas:langStringPreferredNameTypeIec61360>
                  <aas:language>en</aas:language>
                  <aas:text>Battery Passport</aas:text>
                </aas:langStringPreferredNameTypeIec61360>
              </aas:preferredName>
              <aas:shortName>
                <aas:langStringShortNameTypeIec61360>
                  <aas:language>EN</aas:language>
                  <aas:text>BatteryPass</aas:text>
                </aas:langStringShortNameTypeIec61360>
              </aas:shortName>
              <aas:definition>
                <aas:langStringDefinitionTypeIec61360>
                  <aas:language>en</aas:language>
                  <aas:text>The battery pass describes information collected during the lifecycle of a battery. The battery passport is heavily based on the Regulation (EU) 2023/1542 of the European Parliament and of the Council of 12 July 2023 concerning batteries and waste batteries, amending Directive 2008/98/EC and Regulation (EU) 2019/1020 and repealing Directive 2006/66/EC.
Additionally attributes come from the Proposal for Ecodesign for Sustainable Products Regulation.</aas:text>
                </aas:langStringDefinitionTypeIec61360>
              </aas:definition>
            </aas:dataSpecificationIec61360>
          </aas:dataSpecificationContent>
        </aas:embeddedDataSpecification>
      </aas:embeddedDataSpecifications>
      <aas:assetInformation>
        <aas:assetKind>Type</aas:assetKind>
      </aas:assetInformation>
    </aas:assetAdministrationShell>
BirgitBoss commented 9 months ago

I think this bug was already fixed. We used an older CLI version. This issue can be closed.