search

eclipse-gemoc / gemoc-studio-modeldebugging

gemoc-studio-modeldebugging
Eclipse Public License 1.0
6 stars 15 forks source link

xdsmlFilePath attribute in plugin.xml should contain a path and not an URI #137

Closed dvojtise closed 4 years ago

dvojtise commented 4 years ago

Currently, the languageBuilder set the xdsmlFilePath attribute to indicate the location of the dsl file.

The name of the attribute suggests a path (ie. something like /<nameoftheproject>/foldername/my.dsl ) but it contains an uri such as platform:/plugin/<nameoftheproject>/foldername/my.dsl

We should be consistent in the name and content.

I suggest to use a path which is more portable, as this information may be used by both the modeling workbench (where the uri should be platform:/plugin) and the language workbench (where the uri should be platform:/resource)

dvojtise commented 4 years ago

note: the stored information was a path in older versions but was (wrongly) changed to a URI in https://github.com/eclipse/gemoc-studio-modeldebugging/commit/1ffea5cb81eab1c1ba5effa31414fdb4f3fce69c

https://github.com/eclipse/gemoc-studio-modeldebugging/blob/eabef399a91c188cce0fb4fa6625da416f7f3d82/framework/xdsml_framework/plugins/org.eclipse.gemoc.xdsmlframework.ide.ui/src/org/eclipse/gemoc/xdsmlframework/ide/ui/builder/GemocLanguageProjectBuilder.java#L192