search

eclipse-gemoc / gemoc-studio

gemoc-studio
Eclipse Public License 1.0
25 stars 22 forks source link

All CI build failing on pomfirst build of the Studio since 2023/06/12 #294

Closed dvojtise closed 1 year ago

dvojtise commented 1 year ago

Bug description

all build on the ci fails since yesterday on the pomfirst build https://ci.eclipse.org/gemoc/job/gemoc-studio-integration/job/master/

with the following message

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project org.eclipse.gemoc.commons.eclipse: Compilation failure
[ERROR] /home/jenkins/agent/workspace/gemoc-studio-integration_master/gemoc-studio-commons/pomfirst/org.eclipse.gemoc.commons.eclipse/target/src/main/java/org/eclipse/gemoc/commons/eclipse/core/resources/IFileUtils.java:[62,33] cannot access org.eclipse.core.runtime.jobs.ISchedulingRule
[ERROR]   bad class file: /home/jenkins/.m2/repository/org/eclipse/platform/org.eclipse.core.jobs/3.14.0/org.eclipse.core.jobs-3.14.0.jar(/org/eclipse/core/runtime/jobs/ISchedulingRule.class)
[ERROR]     class file has wrong version 61.0, should be 55.0

This is apparently due to the new version of Eclipse that is available since yesterday.

In our bom we have a dependency to https://central.sonatype.com/artifact/org.eclipse.platform/org.eclipse.core.runtime/3.24.0

But this jar uses a range to org.eclipse.core.runtime.jobs [3.12.0,4.0.0) , apparently a newer version is available and is compiled with java 17 instead of java 11.

Two main actions are possible:

dvojtise commented 1 year ago

My preference goes to move to java 17 as base

Please add a thumb up if you agree, or thumb down if you have concern against this

ebousse commented 1 year ago

I see very few people using an up-to-date JVM, so requiring version 17 may be an annoyance… but we also don't have many users anyway. I'm quite mixed.

dvojtise commented 1 year ago

yes, but looking more closely to the problem and according to https://wiki.eclipse.org/Eclipse/Installation

since eclipse 2022-09 Eclipse requires java 17 (current version of our base is eclipse 2022-06), so we'll also have the issue for eclipse itself when we'll bump to a newer base (and not just those pomfirst jar)

the only real concern is not about moving to java 17 (we have to), but if we need to better control indirect dependencies version in pomfirst or just leave this as it is ...

ebousse commented 1 year ago

Ah, I see, you are correct. Then going to Java 17 is OK for me.

dvojtise commented 1 year ago

I didn't succeed in building by only bumping java version, I also had to bump xtend from 2.25 to 2.27 Since I also planned to bump the studio on the new eclipse version during the summer (as every year) I think I'll do all this in one bigger version bump ... (#167 #270 #298)

ebousse commented 1 year ago

Fixed during summer.