eclipse-glsp / glsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.dev/glsp
Other
195 stars 31 forks source link

Align Interface usage across `*Manager` classes #1393

Closed ndoschek closed 1 week ago

ndoschek commented 3 weeks ago

Follow-up of https://github.com/eclipse-glsp/glsp-client/pull/385

There is an inconsistency in how manager classes are bound, with some using the interface+symbol combination (e.g., IHelperLineManager, IToolManager) and others directly injecting the class (e.g., ChangeBoundsManager and GridManager).

This issue aims to align the remaining *Manager classes to ensure consistent usage of interfaces and bindings. This will involve reviewing the current implementations and making necessary adjustments to follow a consistent pattern across all manager classes. Ensure to maintain backward compatibility by using the bindAsService helper method.