search

eclipse-hawkbit / hawkbit-extensions

Eclipse Public License 2.0
20 stars 30 forks source link

fix: overwritable aws region through application property #24

Closed subhadippramanik closed 6 years ago

subhadippramanik commented 6 years ago

Problem Statement: File upload fails if S3 bucket is not created in eu-central-1

Root Cause: Application not allowing to set region

Solution: AWS region is by default eu-central-1. With application property aws.region this can be over written.

Signed-off-by: Subhadip Pramanik subhadip.pramanik@siemens.com

subhadippramanik commented 6 years ago

I already have signed the ECA, could anyone suggest me if anything else pending?

schabdo commented 6 years ago

Indeed your ECA is present and valid. Have a look at the contribution guide. In addition to the ECA you'll have to sign-off your commit

subhadippramanik commented 6 years ago

OK..my bad. Moved it to a new merge request #26 with sign-off

schabdo commented 6 years ago

Never mind, the new PR is passing the IP validation now. So I close this one. Thanks a lot!