search

eclipse-hawkbit / hawkbit-extensions

Eclipse Public License 2.0
20 stars 30 forks source link

Add multi user extension #43

Closed stschake closed 5 years ago

stschake commented 5 years ago

Allows statically configuring multiple users with specific permissions and details. When loaded but no users are configured, the standard behavior with a single user configured through the security properties is emulated.

hawkbit[bot] commented 5 years ago

Thanks for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. Please make sure you red the contribution guide and signed the Eclipse Contributor Agreement (ECA).

hawkbit-bot commented 5 years ago

Can one of the admins verify this patch?

stschake commented 5 years ago

edit: Now fixed up for Spring Boot 2

schabdo commented 5 years ago

Thanks again for your contribution. Exactly what I had in mind. This will add great value for the community! As I hinted in https://github.com/eclipse/hawkbit/issues/809 I even suggest this extension to be the default in hawkBit. So if you like I encourage you to extend the default implementation of UserDetailsService and move the logic there. Custom user properties are honored in favor of existing default admin user (like you did).

I'll add my remarks to the PR shortly. Nevertheless great job :+1:

stschake commented 5 years ago

I've opened https://github.com/eclipse/hawkbit/pull/829 for a squashed-into-core version of this. Feel free to close either one or let me know how you want to proceed (this one is also updated).

schabdo commented 5 years ago

Thanks a lot @stschake! I'll have a look at https://github.com/eclipse/hawkbit/pull/829

schabdo commented 5 years ago

Closing this PR in favour of eclipse/hawkbit#829