search

eclipse-hawkbit / hawkbit-extensions

Eclipse Public License 2.0
20 stars 30 forks source link

Fix open S3Object InputStream #71

Open herdt-michael opened 3 years ago

herdt-michael commented 3 years ago

Open S3Object InputStream when creating an instance of S3Artifact to make it reusable and prevent a wrong usage because of an unused open InputStream.

Signed-off-by: Michael Herdt Michael.Herdt@bosch.io

bogdan-bondar commented 3 years ago

@hawkbit-bot verify please

hawkbit-bot commented 3 years ago

SonarQube analysis reported 3 issues

Watch the comments in this conversation to review them.

bogdan-bondar commented 3 years ago

Frankly speaking I believe that proposed changes make the code less understandable with S3Artifact being mutable and used in different context (e.g. exists() is a duplicate of existsByTenantAndSha1() but used in different context). We need to define more strict borders of responsibility between S3Artifact and S3Repository.