eclipse-hawkbit / hawkbit-extensions

Eclipse Public License 2.0
20 stars 30 forks source link

s3: implement artifact range requests #95

Open zyga opened 1 year ago

zyga commented 1 year ago

The basic itent is to allow expressing an input stream for a fragment that corresponds to a single range request.

This patch is not ready to land, because it requires lock-step update in HawkBit proper. The long story short, is that the current abstraction of getFileInputStream is just insufficient to efficiently implement range requests for artifacts.

There are two goals for efficiency:

The second problem is somewhat elusive, since S3 input stream has a close() method that informs us of incorrect usage if not all content is drained, when S3 is sending the content but are are not reading.

Corresponging HawkBit change is posted to HawkBit in a separate patch.

Fixes: https://github.com/eclipse/hawkbit-extensions/issues/91

hawkbit-bot commented 1 year ago

Can one of the admins verify this patch?

zyga commented 1 year ago

This depends on https://github.com/eclipse/hawkbit/pull/1445