Remove dependency on Google Guava

eclipse-hono / hono

Eclipse Hono™ Project

https://eclipse.dev/hono

Eclipse Public License 2.0

452 stars 137 forks source link

Remove dependency on Google Guava #1650

Closed sophokles73 closed 4 years ago

sophokles73 commented 4 years ago

We originally introduced the dependency on Guava for its Cache implementation. However, that has been moved to the Caffeine library which we are now using.

We currently only use Guava's ToStringHelper class in some value objects which doesn't seem to justify keeping the dependency. We therefore should replace the usage of ToStringHelper and then remove our dependency on Guava altogether.

ctron commented 4 years ago

There are new more locations using Guava. I will try to replace them as well.

ctron commented 4 years ago

Ok, we are using Guava for:

toStringHelper (service-base, device registry)
Base16 decoding (lorawan, sigfox)
Reading resources (device registry)

Now we could replace all three features with custom code, but I fail to see the benefit now.

sophokles73 commented 4 years ago

Ah, I didn't realize that we used the other features as well. I agree, that in this case we probably should keep Guava (for now) ...