eclipse-hono / hono

Eclipse Hono™ Project
https://eclipse.dev/hono
Eclipse Public License 2.0
449 stars 137 forks source link

Basic auth with username including `@` fails on some LoraWAN network servers. #1949

Closed BobClaerhout closed 4 years ago

BobClaerhout commented 4 years ago

Some network servers(NS) have problems accepanting/sending the current username scheme which is used by Hono. This username contains the @ symbol which is a special character and which should be encoded somehow.
Although this is actually an issue of the LoraWAN NS, I think we can try to fix this within hono. Because the end result is that those NS are not able to connect to Hono.

We discussed this on gitter and also on the last community call and there are 2 possibilities to solve this:

ctron commented 4 years ago

The Sigfox backend does have the same problem.

I would also be in favor of the base64 encoding proposal, as it would provide a way to work without any special character.

sophokles73 commented 4 years ago

@BobClaerhout @ctron is this something that we need to address in all adapters or is this just an issue of the Lora and SigFox, or more generally, the HTTP based adapters?

ctron commented 4 years ago

I would say it is a problem with systems that are used to work with URLs. Because that is where you need to escape this special characters. I guess this makes it a problem of HTTP based adapters (LoRaWAN, Sigfox, HTTP). Because in the context of MQTT and AMQP, you are more used to provide hostname & port, and username & password some kind of additional field, property, …