search

eclipse-hono / hono

Eclipse Hono™ Project
https://eclipse.dev/hono
Eclipse Public License 2.0
452 stars 137 forks source link

Prometheus based resource limit check is hardcoded to use port 9090 only #3647

Closed harism closed 4 months ago

harism commented 4 months ago

Unless I'm mistaken this single line; https://github.com/eclipse-hono/hono/blob/6a05ee38ea9f7ad98e0c15b0e6f3ce40963abb6b/adapter-base/src/main/java/org/eclipse/hono/adapter/resourcelimits/PrometheusBasedResourceLimitChecksConfig.java#L71

Causes it that the documented configurable Prometheus port variable is always overrode with this 9090 value, and the configuration variable hono.resourceLimits.prometheusBased.port coming in the PrometheusBasedResourceLimitCheckOptions constructor parameter has no effect.

sophokles73 commented 4 months ago

I guess you are right.

sophokles73 commented 4 months ago

Fixed via #3648