eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
89 stars 16 forks source link

Early abort on iceoryx build failure #21

Closed elBoberido closed 2 years ago

elBoberido commented 2 years ago

Pre-Review Checklist for the PR Author

  1. [x] Code follows the Rust coding style and is formatted with rustfmt
  2. [x] Branch follows the naming format (iox-#123-this-is-a-branch)
  3. [x] Commits messages are according to this guideline
  4. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x] Relevant issues are linked
  6. [x] Add sensible notes for the reviewer
  7. [x] All checks have passed (except task-list-completed)
  8. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

adoerr commented 2 years ago

@elBoberido attached, please find a build.log file.

Shouldn't the undeclared Error enum actually be a PoshError :thinking:

build.log

elBoberido commented 2 years ago

@elBoberido attached, please find a build.log file.

Shouldn't the undeclared Error enum actually be a PoshError thinking

build.log

Okay, now I know what's going on. Do you have an installed iceoryx at a location where cmake find_package looks for packages?

elBoberido commented 2 years ago

@adoerr please check if the latest commit fixes your build.

adoerr commented 2 years ago

@elBoberido looks good :heavy_check_mark: Thanks for taking care of this :exclamation: