elBoberido commented 2 years ago

Pre-Review Checklist for the PR Author

[x] Code follows the Rust coding style and is formatted with rustfmt
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline
- [x] Commit messages have the issue ID (iox-#42 commit text)
- [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
[x] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

This PR renames the POD marker trait to ShmSend since it fulfills a similar purpose to Send but instead to mark data types to be transferred across thread boundaries it marks data types to be transferred across process boundaries.

Furthermore, there are additional impls for ShmSend.

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #27

codecov-commenter commented 2 years ago

Codecov Report

Merging #33 (03a486e) into master (275e6e0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 03a486e differs from pull request most recent head bb8c96a. Consider uploading reports for the commit bb8c96a to get more accurate results

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   35.32%   35.32%           
=======================================
  Files          15       15           
  Lines        4252     4252           
=======================================
  Hits         1502     1502           
  Misses       2750     2750

Impacted Files	Coverage Δ
src/lib.rs	`42.44% <ø> (ø)`
src/pb/publisher.rs	`32.50% <ø> (ø)`
src/pb/sample.rs	`60.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 275e6e0...bb8c96a. Read the comment docs.