eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
86 stars 16 forks source link

Iox 36 untyped api #58

Closed elBoberido closed 1 year ago

elBoberido commented 1 year ago

Pre-Review Checklist for the PR Author

  1. [x] Code follows the Rust coding style and is formatted with rustfmt
  2. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  3. [x] Commits messages are according to this guideline
  4. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x] Relevant issues are linked
  6. [x] Add sensible notes for the reviewer
  7. [x] All checks have passed (except task-list-completed)
  8. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

codecov-commenter commented 1 year ago

Codecov Report

Merging #58 (1e0284e) into master (a37117a) will increase coverage by 3.73%. The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   51.29%   55.02%   +3.73%     
==========================================
  Files          19       20       +1     
  Lines         774      945     +171     
==========================================
+ Hits          397      520     +123     
- Misses        377      425      +48     
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/introspection/memory.rs 0.00% <ø> (ø)
src/introspection/port.rs 0.00% <ø> (ø)
src/introspection/process.rs 0.00% <ø> (ø)
src/subscriber.rs 47.22% <ø> (ø)
src/sample_mut.rs 70.00% <65.38%> (-17.50%) :arrow_down:
src/sample.rs 59.40% <69.56%> (+4.40%) :arrow_up:
src/publisher.rs 62.75% <76.78%> (+3.35%) :arrow_up:
iceoryx-sys/src/publisher.rs 81.96% <95.12%> (+1.57%) :arrow_up:
iceoryx-sys/src/chunk_header.rs 95.23% <95.23%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a37117a...1e0284e. Read the comment docs.

elBoberido commented 1 year ago

@neilisaac I'm currently implementing the reactor pattern for the WaitSet/Listener. If you are interested, I can ping you once I have a draft PR.