eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
89 stars 16 forks source link

Iox 36 untyped api #58

Closed elBoberido closed 2 years ago

elBoberido commented 2 years ago

Pre-Review Checklist for the PR Author

  1. [x] Code follows the Rust coding style and is formatted with rustfmt
  2. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  3. [x] Commits messages are according to this guideline
  4. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x] Relevant issues are linked
  6. [x] Add sensible notes for the reviewer
  7. [x] All checks have passed (except task-list-completed)
  8. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

codecov-commenter commented 2 years ago

Codecov Report

Attention: Patch coverage is 78.57143% with 48 lines in your changes missing coverage. Please review.

Project coverage is 55.02%. Comparing base (a37117a) to head (1e0284e).

Files with missing lines Patch % Lines
src/sample_mut.rs 65.38% 18 Missing :warning:
src/sample.rs 69.56% 14 Missing :warning:
src/publisher.rs 76.78% 13 Missing :warning:
iceoryx-sys/src/publisher.rs 95.12% 2 Missing :warning:
iceoryx-sys/src/chunk_header.rs 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== + Coverage 51.29% 55.02% +3.73% ========================================== Files 19 20 +1 Lines 774 945 +171 ========================================== + Hits 397 520 +123 - Misses 377 425 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elBoberido commented 2 years ago

@neilisaac I'm currently implementing the reactor pattern for the WaitSet/Listener. If you are interested, I can ping you once I have a draft PR.