eclipse-iceoryx / iceoryx-rs

Rust wrapper for Eclipse iceoryx™ - true zero-copy inter-process-communication
Apache License 2.0
89 stars 16 forks source link

Iox 68 bundle iceoryx cpp source #69

Closed elBoberido closed 1 year ago

elBoberido commented 1 year ago

Pre-Review Checklist for the PR Author

  1. [x] Code follows the Rust coding style and is formatted with rustfmt
  2. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  3. [x] Commits messages are according to this guideline
  4. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. [x] Relevant issues are linked
  6. [x] Add sensible notes for the reviewer
  7. [x] All checks have passed (except task-list-completed)
  8. [ ] Assign PR to reviewer

Notes for Reviewer

This PR added a script to download and bundle the iceoryx C++ sources with the iceoryx-sys crate. This is also recommended procedure from https://kornel.ski/rust-sys-crate#donts

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.27%. Comparing base (68fbd03) to head (330c927).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #69 +/- ## ========================================== - Coverage 55.20% 48.27% -6.93% ========================================== Files 20 19 -1 Lines 942 1075 +133 ========================================== - Hits 520 519 -1 - Misses 422 556 +134 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.