search

eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.58k stars 373 forks source link

failing nightly CI job should prevent Pull-Requests from merging #1608

Open dkroenke opened 1 year ago

dkroenke commented 1 year ago

Brief feature description

To enforce the clang-tidy rules from https://github.com/eclipse-iceoryx/iceoryx/issues/1196 the CI needs to be more strict. A full scan of all files from a list is done in the nightly job.

When this nightly job fails (due to violated clang-tidy rules), it should prevent all Pull-Requests from merging until the nightly job is fixed again. The nightly needs to offer the possibility to be executed on a feature branch to be able to get fixed.

elBoberido commented 1 year ago

How long does it take until the nightly job finishes its run? And more important is the nightly job only triggered at night?

dkroenke commented 1 year ago

How long does it take until the nightly job finishes its run?

It takes around 1,5 - 2 hours for the clang-tidy scan.

And more important is the nightly job only triggered at night?

The job is scheduled to run at 6 AM UTC on working days. Jobs start usually ~ 8.30 AM in Berlin (UTC +2) when the city still sleeps.