Open elBoberido opened 1 year ago
Hello,
I was going to pick this issue up as a side project, after configuring, building and installing with the commands below, I can see the files include/iceoryx/v/iceoryx_versions.hpp
and include/iceoryx/v/iceoryx_hoofs/iceoryx_hoofs_deployment.hpp
are correctly installed with no additional install command (other than the standard cmake one).
Is it possible this issue was fixed in the time since it was opened?
Configure
/usr/bin/cmake --no-warn-unused-cli "-Bbuild -Hiceoryx_meta"
-DBUILD_TEST:BOOL=TRUE
-DBINDING_C:BOOL=TRUE
-DEXAMPLES:BOOL=TRUE
-DCMAKE_INSTALL_PREFIX:STRING=/home/andre/Documents/iceoryx/install
-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE
-DCMAKE_BUILD_TYPE:STRING=Release
-DCMAKE_C_COMPILER:FILEPATH=/usr/bin/gcc
-DCMAKE_CXX_COMPILER:FILEPATH=/usr/bin/g++
-S/home/andre/Documents/iceoryx/iceoryx_meta
-B/home/andre/Documents/iceoryx/build
-G "Unix Makefiles"
Build
/usr/bin/cmake --build /home/andre/Documents/iceoryx/build --config Release --target all -j 18 --
Install
$ cmake --install build
@andre-nguyen sorry, this totally slipped my attention. I think the issue description was not clear enough. It isn't the case that the user has to invoke an additional cmake command but within the CMakeLists.txt
. For example in iceoryx_hoofs/CMakeLists.txt
on line 114/115 the iceoryx_hoofs_deployment.hpp
is generated and on line 117 to 121 it is added to the install files. Ideally this would not be necessary and the iox_add_library
would take care of this.
Brief feature description
Generated header like
iceoryx_version.hpp
oriceoryx_hoofs_deployment.hpp
need to be installed via a separateinstall
command in cmake. Since these files are already part of thetarget_include_headers
it should be installed via this mechanism or alternatively an additional parameter should be added toiox_add_library